Fueled as_specific_collection #31275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
force-pushed
the
fueled_as_collection
branch
from
4711397 to
0e59c31
Compare
teskje
approved these changes
Feb 4, 2025
src/compute/src/render/context.rs
Outdated
| @@ -97,6 +98,24 @@ where | |||
| /// The expiration time for dataflows in this context. The output's frontier should never advance | |||
| /// past this frontier, except the empty frontier. | |||
| pub dataflow_expiration: Antichain<T>, | |||
| /// The flags active in this context. | |||
| pub flags: ContextFlags, | |||
There was a problem hiding this comment.
Have you considered just passing a ConfigSet directly? That would reduce some boilerplate when adding a new config. You could simply access it everywhere that has access to a Context, without needing to change the fields and From implement of ContextFlags. Also makes it possible to dynamically change some configuration at runtime (without recreating the dataflow), should we ever want that.
There was a problem hiding this comment.
Great point! Changed it such that we just have a single Rc<ConfigSet> (updating doesn't require mutability), which seems better than introducing a custom struct.
Adds fueling to `as_specific_collection` by calling into `flat_map` instead of `as_collection`. Add a flag to restore the previous behavior. Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
fueled_as_collection
branch
from
0e59c31 to
bb9691c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fueling to
as_specific_collectionby calling intoflat_mapinsteadof
as_collection. Add a flag to restore the previous behavior.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.