Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Force-destroy terraform only in terraform tests #31284

Merged
merged 1 commit into from
Feb 4, 2025
Merged

ci: Force-destroy terraform only in terraform tests #31284

merged 1 commit into from
Feb 4, 2025

Conversation

def-
Copy link
Contributor

@def- def- commented Feb 4, 2025

Less noisy

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- requested a review from bobbyiliev February 4, 2025 09:32
@def- def- requested a review from a team as a code owner February 4, 2025 09:32
bobbyiliev
bobbyiliev approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Dennis!

@def- def- enabled auto-merge February 4, 2025 09:46
@def- def- merged commit ef6c21a into MaterializeInc:main Feb 4, 2025
80 checks passed
@def- def- deleted the pr-terraform-noise branch February 4, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev bobbyiliev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@def- @bobbyiliev