timely-util: reclock: test binding consolidation #31285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
approved these changes
Feb 4, 2025
src/timely-util/src/reclock.rs
Outdated
|
|
||
| impl Time { | ||
| fn new(time: u64) -> Self { | ||
| INSTANCES.store(INSTANCES.load(Ordering::Relaxed) + 1, Ordering::Relaxed); |
There was a problem hiding this comment.
Looks like the harness only runs a single worker, so this doesn't matter currently, but I think you want INSTANCES.fetch_add(1, Ordering::Relaxed) instead. At the very least it's more readable.
There was a problem hiding this comment.
Ah, you're right, I forgot about that. I had initially implemented it with Cells, until Rust complained about Send and I blindly switched the set/get to store/load. I'll make this a fetch_add
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
force-pushed
the
test-reclock-consolidation
branch
from
2dc58cc to
d5f5433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test the logic added in #31248. The tests tests two extreme scenarios. In the first scenario a single big batch of unconsolidated bindings are presented to the operator. In the second scenario tiny batches of the same number of uncompacted bindings are presented to the operator over multiple steps.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.