Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix glob root dir to respect MZ_ROOT #31289

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

def-
Copy link
Contributor

@def- def- commented Feb 5, 2025

Noticed and fixed for one test by Marty in #31239

Nightly run to verify: https://buildkite.com/materialize/nightly/builds/11050

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Noticed and fixed for one test by Marty in MaterializeInc#31239
@def- def- requested review from petrosagg and martykulma February 5, 2025 09:05
@def- def- enabled auto-merge February 5, 2025 09:32
@def- def- merged commit 0b41158 into MaterializeInc:main Feb 5, 2025
13 of 17 checks passed
@def- def- deleted the pr-glob-root-dir branch February 5, 2025 10:00
@petrosagg
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants