Switch to upstream launchdarkly sdk #31392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
approved these changes
Feb 7, 2025
antiguru
force-pushed
the
update_ld_sdk
branch
from
3470f76 to
786ab4e
Compare
ParkMyCar
approved these changes
Feb 7, 2025
pH14
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Would we lose the connection timeouts in MaterializeInc/rust-server-sdk@59b5740? I'd be OK losing metrics, but having timeouts on all external calls has proven to be very important
Switch to the upstream launchdarkly-server-sdk crate instead of our own fork. This comes at the expense of losing some metrics that we added to our crate but never attempted to upstream. It is not easy to replicate the metrics without creating our own wrapper of the http library (or continue to maintain our own fork). I'd rather lose the metrics over continuing to maintain our own fork because the maintenance will cost time. Signed-off-by: Moritz Hoffmann <[email protected]> # Conflicts: # Cargo.lock # src/balancerd/Cargo.toml
|
Yup, there's no API for setting the timeouts. |
antiguru
force-pushed
the
update_ld_sdk
branch
from
786ab4e to
eac325a
Compare
|
Closing this PR because I don't want to spend more time on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to the upstream launchdarkly-server-sdk crate instead of our own
fork. This comes at the expense of losing some metrics that we added to
our crate but never attempted to upstream. It is not easy to replicate
the metrics without creating our own wrapper of the http library (or
continue to maintain our own fork). I'd rather lose the metrics over
continuing to maintain our own fork because the maintenance will cost time.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.