Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspection maintenance #135

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Inspection maintenance #135

merged 7 commits into from
Feb 14, 2024

Conversation

maxfischer2781
Copy link
Member

@maxfischer2781 maxfischer2781 commented Feb 2, 2024

This PR includes maintenance trigger by recent inspection failures. Notable changes include:

  • Reformat code as per black's yearly format change
  • Extend flake8 config as per black recommendations
    • ignore E203 for slice whitespace
    • ignore E704 for inline type hint elipsis
  • Update to Pytest8 by fixing warning test deprecation
  • Change some do-nothing test blocks to use pass as opposed to ... (which is commonly used for typing omissions only)

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff1d810) 92.68% compared to head (13adaf9) 92.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files          33       33           
  Lines        1108     1108           
  Branches      206      206           
=======================================
  Hits         1027     1027           
  Misses         59       59           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/cobald/interfaces/_partial.py Dismissed Show dismissed Hide dismissed
src/cobald/interfaces/_partial.py Dismissed Show dismissed Hide dismissed
src/cobald/interfaces/_partial.py Dismissed Show dismissed Hide dismissed
src/cobald/interfaces/_partial.py Dismissed Show dismissed Hide dismissed
src/cobald/controller/stepwise.py Dismissed Show dismissed Hide dismissed
src/cobald/controller/stepwise.py Dismissed Show dismissed Hide dismissed
cobald_tests/interfaces/test_partial.py Fixed Show fixed Hide fixed
cobald_tests/interfaces/test_partial.py Fixed Show fixed Hide fixed
cobald_tests/controller/test_stepwise.py Fixed Show fixed Hide fixed
cobald_tests/controller/test_stepwise.py Fixed Show fixed Hide fixed
cobald_tests/controller/test_stepwise.py Fixed Show fixed Hide fixed
cobald_tests/controller/test_stepwise.py Fixed Show fixed Hide fixed
@maxfischer2781 maxfischer2781 marked this pull request as ready for review February 2, 2024 16:22
@maxfischer2781 maxfischer2781 requested review from a team, eileen-kuehn and mschnepf and removed request for a team February 2, 2024 16:22
eileen-kuehn
eileen-kuehn previously approved these changes Feb 5, 2024
Copy link
Member

@eileen-kuehn eileen-kuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to always learn something from the detailed description on the PRs.
Otherwise I am only confused a bit from the codeQL comments and the warnings replacement for pytest.warn. It is much less readable.
But please go for it! 👍

@maxfischer2781
Copy link
Member Author

@eileen-kuehn I think you are right about the warnings test. I've expanded the comment a bit and linked to the docs now, hopefully that makes it less obscure.

Copy link
Member

@eileen-kuehn eileen-kuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may help a lot, thanks! 👍

@maxfischer2781
Copy link
Member Author

@mschnepf pleading puppy eyes 👀

Copy link
Member

@mschnepf mschnepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late approval. I was distracted by some puppy eyes. 🥺
Looks good to me, and the tests 👍

@maxfischer2781 maxfischer2781 added this pull request to the merge queue Feb 14, 2024
Merged via the queue into master with commit 89860d3 Feb 14, 2024
18 checks passed
@maxfischer2781 maxfischer2781 deleted the maintenance/checks20240202 branch February 14, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants