-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspection maintenance #135
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 33 33
Lines 1108 1108
Branches 206 206
=======================================
Hits 1027 1027
Misses 59 59
Partials 22 22 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to always learn something from the detailed description on the PRs.
Otherwise I am only confused a bit from the codeQL comments and the warnings
replacement for pytest.warn
. It is much less readable.
But please go for it! 👍
@eileen-kuehn I think you are right about the warnings test. I've expanded the comment a bit and linked to the docs now, hopefully that makes it less obscure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may help a lot, thanks! 👍
@mschnepf pleading puppy eyes 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late approval. I was distracted by some puppy eyes. 🥺
Looks good to me, and the tests 👍
This PR includes maintenance trigger by recent inspection failures. Notable changes include:
black
's yearly format changepass
as opposed to...
(which is commonly used for typing omissions only)