feat: added base URL configuration #1080
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the standard more closely
|
Not sure if I should be committing the changes made to yarn.lock and the cache? As I have added some packages. |
|
Waiting for this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the functionality of having a root/base URL for the dash. web interface.
Related Issue(s)
Relates to #450
Dev Environment
I have tested this on docker builds (arm64 and amd64) and they are both functioning as expected. I am using Traefik v3 and have 2 separate instances running on different subpaths of the same origin. All the tests pass when run on my local dev environment.
I also compared this to the feature/subpath-hosting branch and the only real difference is I'm not using the url-join package and instead opted for Node polyfills of url and path libraries.