Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 Add background color transparency #45

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

augustVino
Copy link

fix

Copy link

vercel bot commented Feb 7, 2025

Someone is attempting to deploy a commit to the mayandev's projects Team on Vercel.

A member of the Team first needs to authorize it.

@augustVino
Copy link
Author

hi, @Mayandev , please review this pr. feedbacks are appreciated. thank you.

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
notion-avatar ✅ Ready (Inspect) Visit Preview 1 resolved Feb 10, 2025 9:56am

@Mayandev
Copy link
Owner

Thx for your contribution, actually the default background color should be transparent if user don't select the background. And this design is not match the primary color for notion style. But I'll merge your MR first and update the background based on my design.

image

@Mayandev Mayandev merged commit 7809cc7 into Mayandev:main Feb 10, 2025
3 checks passed
@augustVino
Copy link
Author

Thx for your contribution, actually the default background color should be transparent if user don't select the background. And this design is not match the primary color for notion style. But I'll merge your MR first and update the background based on my design.

image

I think what you said is reasonable. My initial idea was to set the default background as transparent, but I saw that in the current design, neither the background shape nor the color is selected by default, so I changed it to require user action to switch.

@augustVino
Copy link
Author

Why am I not added to the list of contributors?😂😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants