Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7812: Update Okta widget to 7.x branch #198

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

sb-benohe
Copy link
Contributor

@sb-benohe sb-benohe commented Oct 17, 2024

MADiE PR

Jira Ticket: MAT-7812
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@sb-benohe sb-benohe requested a review from a team as a code owner October 17, 2024 12:40
@sb-benohe sb-benohe self-assigned this Oct 17, 2024
@sb-benohe sb-benohe added the dependencies Pull requests that update a dependency file label Oct 17, 2024
@sb-benohe sb-benohe changed the title Update Okta widget to 7.x branch MAT-7812: Update Okta widget to 7.x branch Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.77%. Comparing base (722b7ee) to head (7d9de9e).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #198   +/-   ##
========================================
  Coverage    77.77%   77.77%           
========================================
  Files            3        3           
  Lines           18       18           
  Branches         1        1           
========================================
  Hits            14       14           
  Misses           3        3           
  Partials         1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant