Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7118 Action Center Setup #175

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

MAT-7118 Action Center Setup #175

wants to merge 4 commits into from

Conversation

ethankaplan
Copy link
Contributor

@ethankaplan ethankaplan commented Feb 10, 2025

MADiE PR

Jira Ticket: MAT-7118
(Optional) Related Tickets:
MeasureAuthoringTool/madie-util#122
MeasureAuthoringTool/madie-root#264

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@ethankaplan ethankaplan requested a review from a team as a code owner February 10, 2025 20:15
@ethankaplan ethankaplan changed the base branch from develop to MAT-7117 February 10, 2025 20:31
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.82%. Comparing base (673f2b8) to head (83c73ad).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ibraryListActionCenter/draftAction/DraftAction.tsx 82.60% 3 Missing and 1 partial ⚠️
...raryListActionCenter/deleteAction/DeleteAction.tsx 93.75% 1 Missing ⚠️
src/components/cqlLibraryList/CqlLibraryList.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #175      +/-   ##
===========================================
+ Coverage    85.03%   85.82%   +0.79%     
===========================================
  Files           21       25       +4     
  Lines          568      635      +67     
  Branches       118      129      +11     
===========================================
+ Hits           483      545      +62     
- Misses          66       70       +4     
- Partials        19       20       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from MAT-7117 to develop February 11, 2025 21:25
Copy link
Contributor

@mcmcphillips mcmcphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants