Merge pull request #1011 from cjee21/shellext-url

ShellExt: Handle .url files
MediaArea · Jan 14, 2025 · 95a5818 · 95a5818
2 parents ed69a31 + 7b9f450
commit 95a5818
Show file tree

Hide file tree

Showing 3 changed files with 92 additions and 10 deletions.
diff --git a/Source/GUI/Qt/mainwindow.cpp b/Source/GUI/Qt/mainwindow.cpp
@@ -429,7 +429,14 @@ void MainWindow::openFiles(QStringList fileNames) {
     //Configuring
     if(fileNames.isEmpty())
         return;
-    for(int i=0;i<fileNames.size();i++) {
+    for (int i = 0; i < fileNames.size(); ++i) {
+        QUrl url(fileNames[i]);
+        if (url.isValid())
+            if (!url.scheme().isEmpty())
+                if (url.scheme().startsWith("http", Qt::CaseInsensitive) ||
+                    url.scheme().startsWith("ftp", Qt::CaseInsensitive) ||
+                    url.scheme().startsWith("sftp", Qt::CaseInsensitive))
+                    continue;
         fileNames[i] = QDir::toNativeSeparators(fileNames[i]);
     }
     C->Menu_File_Open_Files_Begin(settings->value("closeBeforeOpen",true).toBool(), true);

diff --git a/Source/WindowsShellExtension/dllmain.cpp b/Source/WindowsShellExtension/dllmain.cpp
@@ -33,9 +33,9 @@ BOOL APIENTRY DllMain(_In_ HMODULE hModule, _In_ DWORD  ul_reason_for_call, _In_
 }
 
 namespace {
+
     // Extracted from
     // https://source.chromium.org/chromium/chromium/src/+/main:base/command_line.cc;l=109-159
-
     std::wstring QuoteForCommandLineArg(_In_ const std::wstring& arg) {
         // We follow the quoting rules of CommandLineToArgvW.
         // http://msdn.microsoft.com/en-us/library/17w5ykft.aspx
@@ -185,6 +185,67 @@ namespace {
         return hres;
     }
 
+    // Adapted from code generated with Google Gemini 2.0 Flash
+    _Check_return_ _Success_return_
+    bool ExtractUrlFromShortcut(_In_ const std::filesystem::path& filePath, _Out_ std::string& url) {
+        // Check if file exists and is readable
+        if (!std::filesystem::exists(filePath) || !std::filesystem::is_regular_file(filePath))
+            return false;
+
+        // Open the file in binary mode
+        std::ifstream file(filePath, std::ios::binary);
+
+        // Check if file opened successfully
+        if (!file.is_open())
+            return false;
+
+        // Read the entire file content
+        std::string content;
+        file.seekg(0, std::ios::end);
+        if (file.tellg() > 4096) { // Leave if file is too large
+            file.close();
+            return false;
+        }
+        content.resize(file.tellg());
+        file.seekg(0, std::ios::beg);
+        file.read(&content[0], content.size());
+        file.close();
+
+        // Check if the content starts with the expected header for a .url file
+        if (content.size() < 20 || (content.substr(0, 20).compare("[InternetShortcut]\r\n") != 0))
+            return false;
+
+        // Use regular expression to extract the URL
+        std::regex urlRegex(R"(URL=(.*?)\r?\n)");
+        std::smatch match;
+        if (std::regex_search(content, match, urlRegex)) {
+            url = match[1].str();
+            return true;
+        }
+        else
+            return false;
+    }
+
+    // Adapted from code generated with Google Gemini 2.0 Flash
+    std::string ExtractFileExtensionFromUrl(_In_ const std::string& url) {
+        // Find the last '/' before the '?' or end of string
+        size_t lastSlashPos{ url.find_last_of('/') };
+        size_t queryPos;
+        if (lastSlashPos == std::string::npos)
+            queryPos = url.find('?'); // URLs without slashes
+        else
+            queryPos = url.find('?', lastSlashPos + 1);
+        std::string filename;
+        if (queryPos == std::string::npos)
+            filename = url.substr(lastSlashPos + 1); // URLs without query strings
+        else
+            filename = url.substr(lastSlashPos + 1, queryPos - lastSlashPos - 1);
+
+        // Extract the extension using std::filesystem
+        std::filesystem::path filePath{ filename };
+        return filePath.extension().string();
+    }
+
     // Function to check for supported file extensions
     bool IsSupportedFileExtension(_In_ const std::string& extension) {
         const std::vector<std::string> supported_extensions{
@@ -403,15 +464,22 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
                             if (SUCCEEDED(item->GetDisplayName(SIGDN_FILESYSPATH, &path))) {
                                 std::filesystem::path filepath{ path.get() };
                                 // resolve shortcuts
-                                if (filepath.extension().string().compare(".lnk") == 0) {
-                                    WCHAR target_path[MAX_PATH];
-                                    if (SUCCEEDED(ResolveIt(nullptr, filepath.wstring().c_str(), target_path, sizeof(target_path))))
-                                        filepath = target_path;
+                                if (filepath.extension().string().compare(".url") == 0) {
+                                    std::string url;
+                                    if (ExtractUrlFromShortcut(filepath, url))
+                                        is_supported_extension = IsSupportedFileExtension(ExtractFileExtensionFromUrl(url));
+                                }
+                                else {
+                                    if (filepath.extension().string().compare(".lnk") == 0) {
+                                        WCHAR target_path[MAX_PATH];
+                                        if (SUCCEEDED(ResolveIt(nullptr, filepath.wstring().c_str(), target_path, sizeof(target_path))))
+                                            filepath = target_path;
+                                    }
+                                    if (std::filesystem::is_directory(filepath))
+                                        is_folder = true;
+                                    else
+                                        is_supported_extension = IsSupportedFileExtension(filepath.extension().string());
                                 }
-                                if (std::filesystem::is_directory(filepath))
-                                    is_folder = true;
-                                else
-                                    is_supported_extension = IsSupportedFileExtension(filepath.extension().string());
                             }
                         }
                     }
@@ -496,6 +564,11 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
                 if (SUCCEEDED(result)) {
                     std::filesystem::path filepath{ path.get() };
                     // Resolve shortcuts
+                    if (filepath.extension().string().compare(".url") == 0) {
+                        std::string url;
+                        if (ExtractUrlFromShortcut(filepath, url))
+                            filepath = url;
+                    }
                     if (filepath.extension().string().compare(".lnk") == 0) {
                         WCHAR target_path[MAX_PATH];
                         if (SUCCEEDED(ResolveIt(nullptr, filepath.wstring().c_str(), target_path, sizeof(target_path))))

diff --git a/Source/WindowsShellExtension/pch.h b/Source/WindowsShellExtension/pch.h
@@ -11,7 +11,9 @@
 #include "framework.h"
 
 #include <filesystem>
+#include <fstream>
 #include <string>
+#include <regex>
 
 #include <strsafe.h>