-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShellExt: Option for separate instance #1002
Conversation
Work-in-progress. So far Qt one done and tested to work correctly. VCL one coming next as it is not as easy. |
@JeromeMartinez |
Rebased and added shortcut handling to multi instance. |
Snapshot. |
Just tested the linked build. It is working on my Windows 11 PC. Option shows and toggling it changes behaviour of shell extension. I also get "Invalid index" which I expected as that would happen every time my C++Builder re-saves the Preferences |
I can now have the expected behavior, maybe tester error.
So weird... I'll edit that part of the PR with my own C++ Builder and we'll see. |
a56689b
to
14ea70b
Compare
The latest force push should fix it. I tested and found that just re-saving all the files (master branch) in C++Builder without any changes will cause some data to be changed in The diff: diff --git a/Source/GUI/VCL/GUI_Preferences.dfm b/Source/GUI/VCL/GUI_Preferences.dfm
index 7312fc1b..09fd9063 100644
--- a/Source/GUI/VCL/GUI_Preferences.dfm
+++ b/Source/GUI/VCL/GUI_Preferences.dfm
@@ -38,19 +38,20 @@ object PreferencesF: TPreferencesF
TabOrder = 1
OnChange = TreeChange
Items.NodeData = {
- 0302000000280000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFF000000
- 00010000000105530065007400750070002E0000000000000000000000FFFFFF
- FFFFFFFFFFFFFFFFFF0000000000000000010841006400760061006E00630065
- 006400300000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFF0000000005
- 000000010943007500730074006F006D0069007A006500280000000000000000
- 000000FFFFFFFFFFFFFFFFFFFFFFFF0000000000000000010553006800650065
- 007400340000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFF0000000000
- 000000010B540072006500650020002600200054006500780074003400000000
- 00000000000000FFFFFFFFFFFFFFFFFFFFFFFF0000000000000000010B430075
- 00730074006F006D0020007400650078007400280000000000000000000000FF
- FFFFFFFFFFFFFFFFFFFFFF00000000000000000105470072006100700068002E
- 0000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFF000000000000000001
- 084C0061006E0067007500610067006500}
+ 070200000009540054007200650065004E006F00640065002900000000000000
+ 00000000FFFFFFFFFFFFFFFFFFFFFFFF00000000000100000001055300650074
+ 007500700000002F0000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFF00
+ 0000000000000000010841006400760061006E00630065006400000031000000
+ 0000000000000000FFFFFFFFFFFFFFFFFFFFFFFF000000000005000000010943
+ 007500730074006F006D0069007A0065000000290000000000000000000000FF
+ FFFFFFFFFFFFFFFFFFFFFF000000000000000000010553006800650065007400
+ 0000350000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFF000000000000
+ 000000010B540072006500650020002600200054006500780074000000350000
+ 000000000000000000FFFFFFFFFFFFFFFFFFFFFFFF000000000000000000010B
+ 43007500730074006F006D002000740065007800740000002900000000000000
+ 00000000FFFFFFFFFFFFFFFFFFFFFFFF00000000000000000001054700720061
+ 007000680000002F0000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFF00
+ 000000000000000001084C0061006E0067007500610067006500}
end
object Cancel: TButton
Left = 593 |
The revert looks exactly the same as PR966 fix: https://github.com/MediaArea/MediaInfo/pull/966/files |
Just some changes for style consistency. |
Did not find any issues with the context menu part on Windows 11 24H2 (26100.2894) x64. |
Resolves #1001