Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active sampling capability within desirable feature and target region #8

Merged
merged 14 commits into from
Dec 8, 2023

Conversation

danielchen26
Copy link
Collaborator

The code changes include the addition of a new file, distancebased_active.jl, which allows for setting up desirable_range for active feature constraints, and target_constraints active searching in the dimensional target space.

The rationale behind these changes is to enhance the generative design process by incorporating active sampling, which enables the selection of samples from desirable regions of the feature space and target region. This allows for a more targeted and effective exploration of the design space, leading to improved results in the generative design process. The addition of active sampling capabilities in the GenerativeDesigns module addresses the need for more efficient and focused exploration of the design space, ultimately improving the quality and performance of generative designs.

@thevolatilebit thevolatilebit requested review from thevolatilebit and slwu89 and removed request for slwu89 and thevolatilebit November 28, 2023 20:07
@thevolatilebit thevolatilebit self-requested a review November 29, 2023 01:10
Copy link
Collaborator

@thevolatilebit thevolatilebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielchen26, I suggest adding a paragraph or two on the background of active sampling, including some references. Additionally, as a style tip, I recommend using backticks to highlight names of variables, etc., in the tutorials.

src/GenerativeDesigns/distancebased_active.jl Outdated Show resolved Hide resolved
src/GenerativeDesigns/distancebased_active.jl Outdated Show resolved Hide resolved
@thevolatilebit thevolatilebit changed the title add active sampling capability within desirable feature and target region Add active sampling capability within desirable feature and target region Nov 30, 2023
Copy link
Collaborator

@thevolatilebit thevolatilebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thevolatilebit thevolatilebit merged commit 34588ae into Merck:main Dec 8, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants