331 efficacy and futility boundary update #335
Conversation
|
@nanxstats , please review and edit if you find anywhere inappropriate, but let's wait for Keaven's final approval for merge. |
There was a problem hiding this comment.
This looks nice. Besides the style improvements, I did two things worth mentioning:
I only kept the library(gsDesign2) call and removed all other library() calls, especially for gsDesign and gt, to avoid the function name masking situations on as_gt() and as_rtf(), and possibly others. Then I qualified the namespaces with :: in the code chunks explicitly. This could help minimize potential future issues rooted from "loading packages and change the R landscape", especially when serving as a robust template.
Also, since most code chunks use echo = FALSE, I set that option in the beginning globally and use echo = TRUE in the chunks that do need to echo.
Merge branches '331-efficacyfutility-boundary-update' and '331-efficacyfutility-boundary-update' of https://github.com/Merck/gsDesign2 into 331-efficacyfutility-boundary-update # Conflicts: # vignettes/articles/story-update-boundary.Rmd
Merge branches '331-efficacyfutility-boundary-update' and '331-efficacyfutility-boundary-update' of https://github.com/Merck/gsDesign2 into 331-efficacyfutility-boundary-update # Conflicts: # vignettes/articles/story-update-boundary.Rmd
….com/Merck/gsDesign2 into 331-efficacyfutility-boundary-update
Closes #331