Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out 0 event rows in pw_info #361

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Filter out 0 event rows in pw_info #361

merged 3 commits into from
Mar 18, 2024

Conversation

LittleBeannie
Copy link
Collaborator

@LittleBeannie LittleBeannie commented Mar 18, 2024 •
edited by nanxstats
Loading

Fixes #360

@LittleBeannie LittleBeannie linked an issue Mar 18, 2024 that may be closed by this pull request
Zero failure rates #360
Closed
@LittleBeannie LittleBeannie self-assigned this Mar 18, 2024
@LittleBeannie LittleBeannie marked this pull request as draft March 18, 2024 15:28
@LittleBeannie LittleBeannie marked this pull request as ready for review March 18, 2024 16:54
nanxstats
nanxstats approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have a unit test for this (edge?) case.

@nanxstats nanxstats merged commit 3432bdc into main Mar 18, 2024
8 checks passed
@nanxstats nanxstats deleted the 360-zero-failure-rates branch March 18, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanxstats nanxstats nanxstats approved these changes

@keaven keaven Awaiting requested review from keaven

Assignees

@LittleBeannie LittleBeannie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zero failure rates
2 participants
@LittleBeannie @nanxstats