Code

Clean up summary functions#461

Code

Merged

LittleBeannie merged 43 commits intoMerck:mainMerck/gsDesign2:mainfrom yihui:summary-cleanupyihui/gsDesign2:summary-cleanupCopy head branch name to clipboardSep 5, 2024

+209-544

Commits

Commits on Aug 30, 2024

• purely cosmetic changes

  yihui

  committed
  943121d

  Copy full SHA for 943121d

• use a single paste0()

  yihui

  committed
  6de4e78

  Copy full SHA for 6de4e78

• no need ot do.call(rbind, ...) or apply(..., paste): just paste the first and second elements in x$design_par; also use gsub(fixed = TRUE) to avoid escaping parentheses as \(\)

  yihui

  committed
  b26ed32

  Copy full SHA for b26ed32

• use a regular expression \\U to capitalize the first letter

  Show description for 59047f3
  yihui

  committed
  59047f3

  Copy full SHA for 59047f3

• extra ,

  yihui

  committed
  f163e05

  Copy full SHA for f163e05

• factor out class(x) <- c(..., class(x)) to add_class()

  yihui

  committed
  45f7a59

  Copy full SHA for 45f7a59

• always add newline to files

  yihui

  committed
  a0830bd

  Copy full SHA for a0830bd

• factor out get_method()

  yihui

  committed
  23f4207

  Copy full SHA for 23f4207

• merge all these if statements

  yihui

  committed
  ea50328

  Copy full SHA for ea50328

• ans should inherit classes from x instead of ans

  yihui

  committed
  0c3190e

  Copy full SHA for 0c3190e

• no need to create the object x_design; just assign to ans$design

  yihui

  committed
  cefeb5f

  Copy full SHA for cefeb5f

• untangle this complicated if-else hairball

  Show description for e3eaa16
  yihui

  committed
  e3eaa16

  Copy full SHA for e3eaa16

• factor out replace_values()

  yihui

  committed
  a405832

  Copy full SHA for a405832

• batch capitalize variable names

  yihui

  committed
  fdf14ae

  Copy full SHA for fdf14ae

• the mutate_at() can be a simple <- assignment to column, and the filter() can be simply indexing by name from col_decimals; then all if statments can be merged into a for loop

  yihui

  committed
  df565fd

  Copy full SHA for df565fd

• use add_class()

  yihui

  committed
  84a2754

  Copy full SHA for 84a2754

• use %||%

  yihui

  committed
  920b18c

  Copy full SHA for 920b18c

• store col_vars in the names of col_decimals, and use names when we need to access the col_vars

  yihui

  committed
  b263d07

  Copy full SHA for b263d07

Commits on Aug 31, 2024

• factor out get_decimals()

  yihui

  committed
  84c46db

  Copy full SHA for 84c46db

• also apply get_decimals() to analysis variables and decimals, and rename columns in analyses

  yihui

  committed
  08674f9

  Copy full SHA for 08674f9

Commits on Sep 3, 2024

• an alternative way to replace values in a vector

  yihui

  committed
  7401dbe

  Copy full SHA for 7401dbe

• a simple helper function rename_to() to rename objects

  yihui

  committed
  59c939c

  Copy full SHA for 59c939c

• the columns have already been renamed before, and bound names have also been updated, so only need to add the Null hypothesis column

  yihui

  committed
  2b3de00

  Copy full SHA for 2b3de00

Commits on Sep 4, 2024

• don't round() if digits is not provided

  yihui

  committed
  c18b536

  Copy full SHA for c18b536

• simplify table_ab()

  yihui

  committed
  a54fcf2

  Copy full SHA for a54fcf2

• rewrite round_df()

  yihui

  committed
  d223dc0

  Copy full SHA for d223dc0

• factor out huge amount of code for renaming, and I'm too tired to explain it...

  yihui

  committed
  004af38

  Copy full SHA for 004af38

Commits on Sep 5, 2024

• factor out x$design_par

  yihui

  committed
  2c70436

  Copy full SHA for 2c70436

• use the rename function

  yihui

  committed
  0a69d8b

  Copy full SHA for 0a69d8b

• rename_to -> replace_names

  yihui

  committed
  b7c5c87

  Copy full SHA for b7c5c87

• get rid of the dplyr:: qualifiers

  yihui

  committed
  d00be63

  Copy full SHA for d00be63

• cosmetic

  yihui

  committed
  3c505d9

  Copy full SHA for 3c505d9

• I think group_by() has sorted the data implicitly, so no need to arrange() again

  yihui

  committed
  c7ab5be

  Copy full SHA for c7ab5be

• one assignment

  yihui

  committed
  9cde29a

  Copy full SHA for 9cde29a

• rename analysis header and bound details with the same function cap_names()

  yihui

  committed
  494e354

  Copy full SHA for 494e354

• also use cap_names() for fixed design

  yihui

  committed
  df032cc

  Copy full SHA for df032cc

• unnecessary to create the two objects analysis_header and bound_details; just use analyses and xy

  yihui

  committed
  f724c3b

  Copy full SHA for f724c3b

• remove unused argument of replace_values()

  yihui

  committed
  774e3e4

  Copy full SHA for 774e3e4

• apply cap_names() on col_decimals

  yihui

  committed
  9d66828

  Copy full SHA for 9d66828

• <- [ci skip]

  yihui

  committed
  92d2bfe

  Copy full SHA for 92d2bfe

• import stats for setNames()

  yihui

  committed
  4f1de2a

  Copy full SHA for 4f1de2a

• explain the substitute() trick

  yihui

  committed
  b1a18fb

  Copy full SHA for b1a18fb

• only import stats::setNames() since stats has filter(), which conflicts with dplyr::filter()

  yihui

  committed
  9ba6c87

  Copy full SHA for 9ba6c87