Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove seed setting and replace \dontrun{} with \donttest{} #55

Merged
merged 5 commits into from
Dec 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@
^LICENSE_THIRD_PARTY\.md$
^\.github$
^codecov\.yml$
^tests/testthat/_snaps$
^tests/testthat/_snaps$
^cran-comments\.md$
1 change: 0 additions & 1 deletion R/meta_sl_example.R
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ meta_sl_exposure_example <- function() {
adexsum$APERIODC <- "Base"
adexsum$APERIOD <- 1

set.seed(123) # Set a seed for reproducibility
adexsum$AVAL <- sample(x = 0:(24 * 7), size = length(adexsum$USUBJID), replace = TRUE)
adexsum$EXDURGR <- "not treated"
adexsum$EXDURGR[adexsum$AVAL >= 1] <- ">=1 day and <7days"
Expand Down
2 changes: 1 addition & 1 deletion R/rtf_base_char_subgroup.R
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#' @export
#'
#' @examples
#' \dontrun{
#' \donttest{
#' meta <- meta_sl_example()
#'
#' outdata <- prepare_base_char_subgroup(
Expand Down
6 changes: 6 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
## Resubmission v0.1.0

This is a resubmission. In this version, I have fixed the issues identified in v0.1.0:

- Remove seed setting in `meta_sl_example()` to avoid to specify a seed in a function.
- Replace `\dontrun{}` with `\donttest{}` for an example of `rtf_base_char_subgroup()`.
2 changes: 1 addition & 1 deletion man/rtf_base_char_subgroup.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tests/testthat/test-independent-testing-rtf_exp_duration.R
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
library(metalite)

set.seed(123)
metatest <- meta_sl_exposure_example()

outdata <- prepare_sl_summary(
Expand Down
Loading