Cleanup Nix code #163
Cleanup Nix code #163
Conversation
9999years
force-pushed
the
rebeccat/nix-cleanup
branch
2 times, most recently
from
dcebedc to
14ff6c8
Compare
9999years
force-pushed
the
rebeccat/nix-cleanup
branch
from
14ff6c8 to
52401b6
Compare
| @@ -0,0 +1,65 @@ | |||
| { | |||
There was a problem hiding this comment.
I think there's still the old version of this function in nix/overlays/lib.nix, which you can probably delete now
There was a problem hiding this comment.
That's in mercury-web-backend!
There was a problem hiding this comment.
Oh, whoops! I didn't notice this was a different repo 😅. Never mind me, then.
flake.nix
Outdated
| }: let | ||
| eachSystem = nixpkgs.lib.genAttrs (import systems); | ||
|
|
||
| makeNixpkgs = { |
There was a problem hiding this comment.
Usually for Nix code I reserve the term "nixpkgs" to refer to the Nixpkgs source code and use the term "pkgs" or "packages" to refer to the actual attribute set of packages instantiated from the Nixpkgs source code. So I'd suggest calling this utility makePkgs instead of makeNixpkgs (also because it creates the pkgs variable, so the name would more closely match the result it is used to create).
Gives us actual packages, makes the definitions all a bit nicer.