Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'All good!' message when reloads finish #167

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add 'All good!' message when reloads finish #167

merged 1 commit into from
Nov 30, 2023

Conversation

9999years
Copy link
Member

is there a plan to add “All good!” to ghciwatch? the green text gives me dopamine

@linear Linear
Copy link

linear bot commented Nov 30, 2023

DUX-1503 “All good!” when reloads finish

@github-actions github-actions bot added the patch Bug fixes or non-functional changes label Nov 30, 2023
@9999years 9999years merged commit 17e230a into main Nov 30, 2023
30 checks passed
@9999years 9999years deleted the rebeccat/dux-1503-all-good-when-reloads-finish branch November 30, 2023 23:26
@github-actions GitHub Actions
Copy link
Contributor

A PR to release these changes has been created, bumping the version from 0.5.2 to 0.5.3.

@9999years 9999years mentioned this pull request Dec 5, 2023
Merged
9999years added a commit that referenced this pull request Dec 5, 2023
@9999years
Make the compilation failed message visible (#174)
1149b3b 
Make the "compilation failed" message error-level rather than
debug-level. The `ghci` error output does generally show when
compilation fails, but without a visible prompt it's not super clear
when exactly compilation finished. This is a follow-up to #167 + #170,
which added an "All good!" message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parsonsmatt parsonsmatt parsonsmatt approved these changes

@Gabriella439 Gabriella439 Awaiting requested review from Gabriella439

Assignees
No one assigned
Labels
patch Bug fixes or non-functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@9999years @parsonsmatt