Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GhciWriter public #183

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Make GhciWriter public #183

merged 3 commits into from
Dec 8, 2023

Conversation

evanrelf
Copy link
Member

@evanrelf evanrelf commented Dec 7, 2023

I need to use it from main in the bin target.

@evanrelf
Make GhciWriter public
56e685a 
I need to use it from `main` in the bin target.
@evanrelf
Document GhciWriter
ec18566 
Because the crate has `#![deny(missing_docs)]`.
@evanrelf
Hide enum variants
4dd78ed 
Makes the correct usage more obvious, removes the need to document the
variants.
@evanrelf evanrelf requested a review from 9999years December 7, 2023 23:56
@github-actions github-actions bot added the patch Bug fixes or non-functional changes label Dec 7, 2023
@9999years
Copy link
Member

I think this is fine, though I'd prefer to keep as much logic out of main.rs as possible.

@evanrelf evanrelf enabled auto-merge (squash) December 8, 2023 00:02
@evanrelf evanrelf changed the title Make GhciWriter public Make GhciWriter public Dec 8, 2023
@evanrelf evanrelf merged commit d2725f3 into main Dec 8, 2023
30 checks passed
@evanrelf evanrelf deleted the evan/pub-ghciwriter branch December 8, 2023 00:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

A PR to release these changes has been created, bumping the version from 0.5.5 to 0.5.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9999years 9999years 9999years approved these changes

Assignees
No one assigned
Labels
patch Bug fixes or non-functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanrelf @9999years