Check all events in logged_in_checkpoint
#218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
force-pushed
the
rebeccat/logged-in-checkpoint-all-events
branch
from
e7c567c to
830c796
Compare
In the test harness, we use methods like `assert_logged_in_checkpoint` and `assert_logged_or_wait` to find events in a checkpoint. These methods error when no matching event is found and when the matcher errors. Matcher errors are important -- the `NegativeMatcher` will error if its contained matcher matches an event, so we need to: 1. Check every event in the checkpoint when using these methods, even if we find a matching event early. 2. Have a separate method that only errors if the matcher errors (to distinguish between "matching failed" and "no matching event was found") -- this lets `assert_logged_or_wait` distinguish between a matcher error (which should be propagated) and a missing event (so that it can wait for an event to be logged).
9999years
force-pushed
the
rebeccat/logged-in-checkpoint-all-events
branch
from
830c796 to
6c8805a
Compare
Gabriella439
approved these changes
Apr 11, 2024
Comment on lines
+413
to
+414
| if matcher.matches(event)? && ret.is_none() { | ||
| ret = Some(event) |
There was a problem hiding this comment.
Minor nitpick, but I think this is equivalent:
Suggested change
| if matcher.matches(event)? && ret.is_none() { | |
| ret = Some(event) | |
| if matcher.matches(event)? { | |
| return Ok(Some(event)) |
There was a problem hiding this comment.
That short-circuits and doesn't give the matcher a chance to error on later events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test harness, we use methods like
assert_logged_in_checkpointandassert_logged_or_waitto find events in a checkpoint. These methods error when no matching event is found and when the matcher errors.Matcher errors are important -- the
NegativeMatcherwill error if its contained matcher matches an event, so we need to:assert_logged_or_waitdistinguish between a matcher error (which should be propagated) and a missing event (so that it can wait for an event to be logged).