[DUX-3004]: handle evil clients that send ANSI escapes after NL #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I probably should shove an integration test in there as well, since maybe hspec might do new and creative evil stuff in the future. OTOH this seems like a pain and we have a regression test for the internal logic at least. |
Wew. That was a bug. The reproducer is here: https://github.com/rampion/ghciwatch-bug-demo After tracing `consume_str`, I found out that the cause of our problems is that hspec includes the NL in their coloured output before resetting colour. https://github.com/hspec/hspec/blob/fb9916f07e580f2572220d381e1886e765df95b7/hspec-core/src/Test/Hspec/Core/Formatters/Internal.hs#L297-L306 That means that it is a pain in the ass to parse, since it shoves random ANSI escapes onto the next line. The easiest, and probably most correct, solution to this is to just eat ANSI escapes while looking for markers.
lf-
force-pushed
the
jadel/dux-3004--color-prevents-tests-from-being-run
branch
from
29ec75c to
744f6fb
Compare
9999years
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
I guess this is fine? We could also relax the constraint that matches happen at the start of the line, but that's probably a more invasive change. I do wonder if there's other libraries that don't write a trailing newline though.
Actually, I just checked, and putStr "puppy" has the same problem. We probably do need to just fix this so it doesn't require the prompt is on the start of the line.
Happy to merge this as a first-line bugfix, but we should do a more complete fix soon (#346).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wew. That was a bug.
The reproducer is here: https://github.com/rampion/ghciwatch-bug-demo
After tracing
consume_str, I found out that the cause of our problems is that hspec includes the NL in their coloured output before resetting colour.https://github.com/hspec/hspec/blob/fb9916f07e580f2572220d381e1886e765df95b7/hspec-core/src/Test/Hspec/Core/Formatters/Internal.hs#L297-L306
That means that it is a pain in the ass to parse, since it shoves random ANSI escapes onto the next line. The easiest, and probably most correct, solution to this is to just eat ANSI escapes while looking for markers.
patch,minor, ormajorto request a version bump when it's merged.docs/.tests/.