Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sealed Classes and SubClasses #10

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Conversation

chrisjenx
Copy link
Collaborator

@chrisjenx chrisjenx commented Jan 23, 2025

Changes the path query to enable subclassing of the child value class which support subclassing
Fixes bug where will get an uptodate receiver of the subclass to check if it's inline or not
Enables path support for sealed classes (which use array polymorphic serialization)
Also fixes #9 (including bools)

@chrisjenx chrisjenx requested review from JvmName, a team and carmflores January 23, 2025 00:47
Copy link
Member

@JvmName JvmName left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM, just one small comment/question!

Pretty sweet that sealed class support was basically just encoding it in fieldNames!

@chrisjenx chrisjenx merged commit 68ac1c9 into main Jan 23, 2025
2 checks passed
@chrisjenx chrisjenx deleted the cj/when-case-sealed branch January 23, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Int values can't be queried against
2 participants