chore: more code cleanup

MercuryWorkshop · Dec 9, 2024 · a5a99ea · a5a99ea
1 parent f022024
commit a5a99ea
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 23 deletions.
diff --git a/src/client/client.ts b/src/client/client.ts
@@ -126,18 +126,18 @@ export class ScramjetClient {
 				get: (target, prop: string) => {
 					if (prop in target) {
 						return target[prop];
-					} else {
-						const split = prop.split(".");
-						const realProp = split.pop();
-						const realTarget = split.reduce((a, b) => a?.[b], this.global);
+					}
 
-						if (!realTarget) return;
+					const split = prop.split(".");
+					const realProp = split.pop();
+					const realTarget = split.reduce((a, b) => a?.[b], this.global);
 
-						const original = Reflect.get(realTarget, realProp);
-						target[prop] = original;
+					if (!realTarget) return;
 
-						return target[prop];
-					}
+					const original = Reflect.get(realTarget, realProp);
+					target[prop] = original;
+
+					return target[prop];
 				},
 			}
 		);
@@ -147,21 +147,18 @@ export class ScramjetClient {
 				get: (target, prop: string) => {
 					if (prop in target) {
 						return target[prop];
-					} else {
-						const split = prop.split(".");
-						const realProp = split.pop();
-						const realTarget = split.reduce((a, b) => a?.[b], this.global);
+					}
 
-						if (!realTarget) return;
+					const split = prop.split(".");
+					const realProp = split.pop();
+					const realTarget = split.reduce((a, b) => a?.[b], this.global);
 
-						const original = nativeGetOwnPropertyDescriptor(
-							realTarget,
-							realProp
-						);
-						target[prop] = original;
+					if (!realTarget) return;
 
-						return target[prop];
-					}
+					const original = nativeGetOwnPropertyDescriptor(realTarget, realProp);
+					target[prop] = original;
+
+					return target[prop];
 				},
 			}
 		);

diff --git a/src/client/dom/attr.ts b/src/client/dom/attr.ts
@@ -65,10 +65,18 @@ export default function (client: ScramjetClient, _self: typeof window) {
 
 	client.Trap("Attr.prototype.value", {
 		get(ctx) {
-			return ctx.this.ownerElement?.getAttribute(ctx.this.name);
+			if (ctx.this?.ownerElement) {
+				return ctx.this.ownerElement.getAttribute(ctx.this.name);
+			}
+
+			return ctx.get();
 		},
 		set(ctx, value) {
-			return ctx.this.ownerElement?.setAttribute(ctx.this.name, value);
+			if (ctx.this?.ownerElement) {
+				return ctx.this.ownerElement.setAttribute(ctx.this.name, value);
+			}
+
+			return ctx.set(value);
 		},
 	});
 }
diff --git a/src/client/dom/element.ts b/src/client/dom/element.ts
@@ -143,6 +143,12 @@ export default function (client: ScramjetClient, self: typeof window) {
 		},
 	});
 
+	client.Proxy("Element.prototype.getAttributeNode", {
+		apply(ctx) {
+			if (ctx.args[0].startsWith("scramjet-attr")) return ctx.return(null);
+		},
+	});
+
 	client.Proxy("Element.prototype.hasAttribute", {
 		apply(ctx) {
 			if (ctx.args[0].startsWith("scramjet-attr")) return ctx.return(false);