Remove unneeded name global attribute
#1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrost-mo
added
bug
|
|
When XIOS outputs LFRic to seperate streams, it requires there to be a global name attribute on the cube, containing the filename. As this attribute will be different between the different files, preventing merging, we need to remove it during data loading.
jfrost-mo
force-pushed
the
1023_lfric_normalise_name_attribute
branch
from
622104a to
d1d647e
Compare
ukmo-huw-lewis
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When XIOS outputs LFRic to seperate streams, it requires there to be a global name attribute on the cube, containing the filename. As this attribute will be different between the different files, preventing merging, we need to remove it during data loading.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.