chore: fix lint warnings in KeyringController

[mikesposito]

Explanation

Lint warnings in the KeyringController package have been fixed

References

N/A

Changelog

No consumer-facing changes

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

[mcmire]

When you run yarn lint do you see changes to eslint-warning-thresholds.json? If so can you commit those too? You should see numbers go down.

[Gudahtt]

Nit: While @property was certainly not the proper way to document type properties (it's not supported by TSdoc, TypeDoc, or VSCode), we can document them like this:

export type KeyringObject = {
  /**
   * Associated accounts
   */
  accounts: string[];
  /**
   * Keyring type
   */
  type: string;
};

It is nice to have docs for all properties, certainly if they're already documented. I see a few others were deleted in this PR as well

[mikesposito]

Good idea, I added some descriptions on KeyringObject and KeyringControllerState: 1334e78

[mikesposito]

When you run yarn lint do you see changes to eslint-warning-thresholds.json? If so can you commit those too? You should see numbers go down.

@mcmire I updated the file, but now yarn lint is failing on the CI while its working fine on local 🤔 any idea why this is happening?

[mcmire]

@mikesposito Hmm. I am able to replicate the error that CI shows.

Maybe your ESLint cache is out of date? Try running: yarn build:only-clean && yarn ts-node ./scripts/run-eslint.ts (this is the same as the yarn lint:eslint command but minus --cache).

[mcmire]

LGTM!

[ccharly]

Much better now, thanks!

[ccharly]

Ah, thanks for fixing/removing this one 😄 This drove me crazy last time! Might have been a false-positive and the eslint update fixed it!