fix: multichainToken rate for non evm #5175
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salimtb
force-pushed
the
salim/solana-tokens-rate-controller-non-evm
branch
from
51c3893 to
ac5d0e4
Compare
salimtb
commented
Jan 20, 2025
| * @param includeMarketData - Whether to include market data in the response. | ||
| * @returns A promise that resolves to the rate of the token in USD. | ||
| */ | ||
| export function fetchMultiChainRates( |
There was a problem hiding this comment.
this function will be removed and replaced with the one from snap API , but for now we work with mocked data
darkwing
reviewed
Jan 22, 2025
| ): Promise<MarketDataDetailsFromPriceAPi> { | ||
| const url = `http://localhost:3000/v3/spot-prices?assetIds=${assetIds.join( | ||
| ',', | ||
| )}${includeMarketData && `&includeMarketData=true`}${`vsCurrency=usd`}`; |
There was a problem hiding this comment.
Does vsCurrency=usd need an &? &vsCurrency=usd?
There was a problem hiding this comment.
Also, I don't think we need the ${} for vsCurrency=usd
There was a problem hiding this comment.
the api call will be replaced by the snap call below once this one will be ready
for now i'm just using a call to a local fake server, but we will not have api call anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Changelog
@metamask/package-a@metamask/package-bChecklist