feat(accounts-controller): re-publish Snap keyring events #5190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
SnapKeyring
now forward some keyring events coming from a Snap. To avoid having controllers to depend theSnapKeyring
for those new events, we subscribe to them from theAccountsController
and re-publish them from it. This way, theAccountsController
is the sole dependency for those events (and is already a dependency of many controllers anyway).References
Changelog
@metamask/accounts-controller
Checklist