Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create merger and factory for the Caip25Permission #5283

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

ffmcgee725
Copy link
Member

@ffmcgee725 ffmcgee725 commented Feb 5, 2025

Explanation

Addressing https://github.com/MetaMask/MetaMask-planning/issues/4017

We want to create a merger for the Caip25Permission specification in order to enable wallet_addEthereumChain and wallet_switchEthereumChain to call to the PermissionController rather than the ApprovalController for incremental permission requests (i.e. for the permittedChains flow).

References

Extension: MetaMask/metamask-extension#30042

Changelog

@metamask/multichain-api

  • BREAKING: Renamed mergeScopes to mergeNormalizedScopes
  • ADDED: Added merger to CaveatSpecification returned by caip25CaveatBuilder()
  • ADDED: Added mergeInternalScopes which merges two InternalScopesObjects

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ffmcgee725 ffmcgee725 requested a review from jiexi February 5, 2025 17:19
@ffmcgee725
Copy link
Member Author

@metamaskbot publish-preview

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "22.0.0-preview-99939da3",
  "@metamask-previews/address-book-controller": "6.0.2-preview-99939da3",
  "@metamask-previews/announcement-controller": "7.0.2-preview-99939da3",
  "@metamask-previews/approval-controller": "7.1.2-preview-99939da3",
  "@metamask-previews/assets-controllers": "47.0.0-preview-99939da3",
  "@metamask-previews/base-controller": "7.1.1-preview-99939da3",
  "@metamask-previews/build-utils": "3.0.2-preview-99939da3",
  "@metamask-previews/composable-controller": "10.0.0-preview-99939da3",
  "@metamask-previews/controller-utils": "11.4.5-preview-99939da3",
  "@metamask-previews/earn-controller": "0.0.0-preview-99939da3",
  "@metamask-previews/ens-controller": "15.0.1-preview-99939da3",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-99939da3",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-99939da3",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-99939da3",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-99939da3",
  "@metamask-previews/keyring-controller": "19.0.5-preview-99939da3",
  "@metamask-previews/logging-controller": "6.0.3-preview-99939da3",
  "@metamask-previews/message-manager": "12.0.0-preview-99939da3",
  "@metamask-previews/multichain": "2.1.0-preview-99939da3",
  "@metamask-previews/multichain-transactions-controller": "0.1.0-preview-99939da3",
  "@metamask-previews/name-controller": "8.0.2-preview-99939da3",
  "@metamask-previews/network-controller": "22.1.1-preview-99939da3",
  "@metamask-previews/notification-services-controller": "0.18.0-preview-99939da3",
  "@metamask-previews/permission-controller": "11.0.5-preview-99939da3",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-99939da3",
  "@metamask-previews/phishing-controller": "12.3.1-preview-99939da3",
  "@metamask-previews/polling-controller": "12.0.2-preview-99939da3",
  "@metamask-previews/preferences-controller": "15.0.1-preview-99939da3",
  "@metamask-previews/profile-sync-controller": "5.0.0-preview-99939da3",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-99939da3",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-99939da3",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-99939da3",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-99939da3",
  "@metamask-previews/signature-controller": "23.2.0-preview-99939da3",
  "@metamask-previews/token-search-discovery-controller": "1.0.0-preview-99939da3",
  "@metamask-previews/transaction-controller": "44.1.0-preview-99939da3",
  "@metamask-previews/user-operation-controller": "23.0.0-preview-99939da3"
}

@ffmcgee725 ffmcgee725 marked this pull request as ready for review February 11, 2025 18:10
@ffmcgee725 ffmcgee725 requested a review from a team as a code owner February 11, 2025 18:10
@ffmcgee725 ffmcgee725 requested a review from jiexi February 11, 2025 23:38
@ffmcgee725 ffmcgee725 requested a review from jiexi February 12, 2025 17:12
@ffmcgee725 ffmcgee725 requested a review from jiexi February 12, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants