-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create merger and factory for the Caip25Permission #5283
Open
ffmcgee725
wants to merge
18
commits into
main
Choose a base branch
from
jc/merger-caip25-permission
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+548
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffmcgee725
commented
Feb 5, 2025
jiexi
reviewed
Feb 5, 2025
jiexi
reviewed
Feb 5, 2025
jiexi
reviewed
Feb 5, 2025
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
ffmcgee725
commented
Feb 11, 2025
jiexi
reviewed
Feb 12, 2025
jiexi
reviewed
Feb 12, 2025
jiexi
reviewed
Feb 12, 2025
jiexi
reviewed
Feb 12, 2025
jiexi
reviewed
Feb 12, 2025
jiexi
reviewed
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Addressing https://github.com/MetaMask/MetaMask-planning/issues/4017
We want to create a merger for the Caip25Permission specification in order to enable wallet_addEthereumChain and wallet_switchEthereumChain to call to the PermissionController rather than the ApprovalController for incremental permission requests (i.e. for the permittedChains flow).
References
Extension: MetaMask/metamask-extension#30042
Changelog
@metamask/multichain-api
mergeScopes
tomergeNormalizedScopes
caip25CaveatBuilder()
mergeInternalScopes
which merges twoInternalScopesObject
sChecklist