Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/299.0.0 #5318

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Release/299.0.0 #5318

wants to merge 26 commits into from

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Feb 13, 2025

Explanation

This is a controller release that includes the first version of the MultichainNetworkController, which also include AccountController updates. The other version bumps are related to keeping dependencies in sync between all packages.

References

Related to: #804

Changelog

@metamask/accounts-controller

Added

  • BREAKING: Add @metamask/network-controller ^22.2.2 as a dev and peer dependency (#5215)
  • BREAKING: Added MultichainNetworkController:didNetworkChange to allowed events and handle keeping accounts in sync with network changes (#5215)

Changed

  • BREAKING: Bump @metamask/keyring-controller peer dependency from ^19.0.0 to ^19.1.0 (#5215)

@metamask/assets-controllers

Changed

  • BREAKING: Bump @metamask/network-controller dev and peer dependency from ^22.2.1 to ^22.2.2
  • BREAKING: Bump @metamask/accounts-controller dev and peer dependency from ^23.1.0 to ^24.0.0

@metamask/earn-controller

Changed

  • BREAKING: Bump @metamask/network-controller dev and peer dependency from ^22.2.1 to ^22.2.2
  • BREAKING: Bump @metamask/accounts-controller dev and peer dependency from ^23.1.0 to ^24.0.0

@metamask/multichain

Changed

  • BREAKING: Bump @metamask/network-controller dev and peer dependency from ^22.2.1 to ^22.2.2

@metamask/multichain-network-controller

Added

  • Initial release of MultichainNetworkController to handle both EVM and non-EVM network and account switching (#5215)
  • Added allowed actions - NetworkControllerGetStateAction | NetworkControllerSetActiveNetworkAction. The MultichainNetworkController acts as a proxy for the NetworkController and will update it based on EVM network changes.
  • Added allowed events - AccountsControllerSelectedAccountChangeEvent to allowed events. This is used to subscribe to the AccountsController:selectedAccountChange event from the AccountsController and is responsible for updating active network based on account changes (both EVM and non-EVM).

@metamask/multichain-transactions-controller

Changed

  • BREAKING: Bump @metamask/accounts-controller dev and peer dependency from ^23.1.0 to ^24.0.0

@metamask/network-controller

Fixed

  • RpcService: Regard node-fetch errors as retriable (#5298)

@metamask/notification-services-controller

Changed

  • BREAKING: Bump @metamask/profile-sync-controller dev and peer dependency from ^7.0.1 to ^8.0.0

@metamask/profile-sync-controller

Changed

  • BREAKING: Bump @metamask/network-controller dev and peer dependency from ^22.2.1 to ^22.2.2
  • BREAKING: Bump @metamask/accounts-controller dev and peer dependency from ^23.1.0 to ^24.0.0
  • feat: expose all user storage methods through messenger actions (#5311)

@metamask/signature-controller

Changed

  • BREAKING: Bump @metamask/network-controller dev and peer dependency from ^22.2.1 to ^22.2.2

@metamask/transaction-controller

Changed

  • BREAKING: Bump @metamask/network-controller dev and peer dependency from ^22.2.1 to ^22.2.2
  • BREAKING: Bump @metamask/accounts-controller dev and peer dependency from ^23.1.0 to ^24.0.0

@metamask/user-operation-controller

Changed

  • BREAKING: Bump @metamask/network-controller dev and peer dependency from ^22.2.1 to ^22.2.2
  • BREAKING: Bump @metamask/transaction-controller dev and peer dependency from ^45.1.0 to ^46.0.0

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Cal-L Cal-L requested review from a team as code owners February 13, 2025 00:53
Copy link

socket-security bot commented Feb 13, 2025

@Cal-L Cal-L marked this pull request as draft February 13, 2025 01:05
@@ -1,6 +1,6 @@
{
"name": "@metamask/notification-services-controller",
"version": "0.20.1",
"version": "1.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep this as a v0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a "breaking" peer dependency bump. But it sounds like it isn't active in the app yet? Would 0.21.0 work in that case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the previous releases, we usually just bumped the minor for this one yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep perfect!

@@ -7,4 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

[Unreleased]: https://github.com/MetaMask/core/
## [1.0.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not make it a major one for now.

We know we will have some fixes already, I would just go with 0.1.0 for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants