Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devDeps: resolutions: git-url-parse@^12=>13.1.0 #18735

Closed
wants to merge 1 commit into from
Closed

devDeps: resolutions: git-url-parse@^12=>13.1.0 #18735

wants to merge 1 commit into from

Conversation

legobeat
Copy link
Contributor

Explanation

Depended on from now abandoned @storybook/storybook-deployer

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Apr 22, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat marked this pull request as ready for review April 22, 2023 04:36
@legobeat legobeat requested a review from a team as a code owner April 22, 2023 04:36
@legobeat legobeat requested a review from digiwand April 22, 2023 04:36
@legobeat
Copy link
Contributor Author

Consolidated into #18739

@legobeat legobeat closed this Apr 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand Awaiting requested review from digiwand digiwand is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file type-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@legobeat