feat: Add new completion_time_onchain property to Transaction Finalized events

[pedronfigueiredo]

Description

The new property completion_time_onchain has the number of seconds (rounded to the hundredths) between submitted time and the block timestamp.

This number is necessarily lower than the previously existing completion_time property, which captures the time between block validation and UI finalization and depends on the polling interval.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3503

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [af59f40]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1837 ± 182 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	317	2682	1613	499	240
		domContentLoaded	1455	2716	1814	373	179
		load	1501	2746	1837	378	182
		domInteractive	25	223	65	57	27
		backgroundConnect	10	70	28	18	9
		firstReactRender	16	100	44	28	13
		getState	5	77	23	23	11
		initialActions	0	0	0	0	0
		loadScripts	1083	2052	1367	292	140
		setupStore	6	89	17	21	10
		uiStartup	1697	3098	2113	425	204

[matthewwalsh0]

Minor, could we use some extra variables here to make this logic more readable?

[matthewwalsh0]

Minor, constants at top of file with extra context?

[pedronfigueiredo]

Since this is only really going to be used in this function, I find it better to keep it as local constant, which makes it easier to understand its context too.

[matthewwalsh0]

Minor, but is it worth a unit test given the amount of logic in this file?