Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide you received until bridge tx done (#29411) #29520

Open
wants to merge 1 commit into
base: Version-v12.10.0
Choose a base branch
from

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Jan 8, 2025

Description

Open in GitHub Codespaces

This PR cherry picks 9deeadd into the 12.10.0 RC.

This PR fixes an issue where the "You Received" row in the Activity item for a bridge tx would be partially filled in. Now we just hide it until the bridge tx completes and we have all the necessary data to display the row properly.

Related issues

Fixes:

Manual testing steps

  1. Start a bridge tx
  2. Get navigated to Activity list
  3. Click on bridge tx
  4. Observe that "You received" is not present until the bridge is completed.

Screenshots/Recordings

Before

After

Screen.Recording.2024-12-20.at.4.31.37.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29411?quickstart=1)

This PR fixes an issue where the "You Received" row in the Activity item
for a bridge tx would be partially filled in. Now we just hide it until
the bridge tx completes and we have all the necessary data to display
the row properly.

## **Related issues**

Fixes:

## **Manual testing steps**

1. Start a bridge tx
2. Get navigated to Activity list
3. Click on bridge tx
4. Observe that "You received" is not present until the bridge is
completed.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->



https://github.com/user-attachments/assets/e8c3eb2e-9fd7-429b-a119-319defc42bda



## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@infiniteflower infiniteflower marked this pull request as ready for review January 8, 2025 18:06
@infiniteflower infiniteflower requested a review from a team as a code owner January 8, 2025 18:06
Copy link
Contributor

github-actions bot commented Jan 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [e0f84ff]
Page Load Metrics (1592 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13941855159213062
domContentLoaded13861800156511756
load13941858159213063
domInteractive2297422512
backgroundConnect884282412
firstReactRender1594482613
getState44614136
initialActions01000
loadScripts9771407114510752
setupStore612821
uiStartup15512123184415675
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.04 KiB (0.04%)
  • ui: -879 Bytes (-0.01%)
  • common: 646 Bytes (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants