Upgrade the projects to use .NET 8 and C# 12 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inakiesteve
previously approved these changes
Nov 16, 2023
inakiesteve
reviewed
Jan 29, 2024
| @@ -96,7 +96,7 @@ private SujetaType Convert(TaxSummary summary) | |||
| { | |||
| return new SujetaType | |||
| { | |||
| Exenta = summary.TaxExempt.Map(items => items.Select(i => Convert(i)).ToArray()).GetOrNull(), | |||
| Exenta = summary.TaxExempt.Match(items => items.Select(i => Convert(i)).ToArray(), _ => null), | |||
There was a problem hiding this comment.
Do we really need this? NoExenta just below uses Map so I would rather have the same behavior in both properties unless there is something else that I am missing? 😅
There was a problem hiding this comment.
Its because of the return type in the map/match, anyway i improved it even further, so for an empty option of a collection, it would return empty collection instead of null.
inakiesteve
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade the projects to use .NET 8 and C# 12
Type of change
Checklist