Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions update #2240

Merged

Conversation

AlvinSchiller
Copy link
Collaborator

@AlvinSchiller AlvinSchiller commented Feb 5, 2024

upload-artifact and download-artifact in v4

Bump actions/download-artifact from 3 to 4
Bump actions/upload-artifact from 3 to 4
Bump geekyeggo/delete-artifact from 2 to 4
-> Possible solution for needed write access token on PRs if implemented (GeekyEggo/delete-artifact#19)

dependabot bot and others added 4 commits February 4, 2024 22:27
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@AlvinSchiller AlvinSchiller added installation legacy_v2 Issues, discussions and PRs related to Version 2.x labels Feb 5, 2024
@coveralls
Copy link

coveralls commented Feb 5, 2024

Pull Request Test Coverage Report for Build 7780616128

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.82%

Totals Coverage Status
Change from base Build 7761223761: 0.0%
Covered Lines: 633
Relevant Lines: 824

💛 - Coveralls

ignore fails for artifact deletion
add write permission for artifact deletion
@AlvinSchiller
Copy link
Collaborator Author

AlvinSchiller commented Feb 5, 2024

@s-martin Only solution i see for now is to remove the cleanup stage (at least until the linked ticket is resolved). The artifacts get then deleted after 2 days (retention).
This would give us less warnings and saves some runtime (v4 saves up to 90% time on up-/download)

@s-martin s-martin changed the title gitub actions update github actions update Feb 7, 2024
@s-martin
Copy link
Collaborator

@s-martin Only solution i see for now is to remove the cleanup stage (at least until the linked ticket is resolved). The artifacts get then deleted after 2 days (retention). This would give us less warnings and saves some runtime (v4 saves up to 90% time on up-/download)

I think that’s a reasonable approach

@AlvinSchiller AlvinSchiller marked this pull request as ready for review February 14, 2024 08:45
@AlvinSchiller AlvinSchiller merged commit 78d465d into MiczFlor:develop Feb 14, 2024
30 of 31 checks passed
@AlvinSchiller AlvinSchiller deleted the fix/gitub_actions_update branch February 14, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation legacy_v2 Issues, discussions and PRs related to Version 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants