Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add api version to mqtt.client for new version 2.0.0 compatibility #2265

Merged
merged 1 commit into from
Feb 19, 2024
Merged

add api version to mqtt.client for new version 2.0.0 compatibility #2265

merged 1 commit into from
Feb 19, 2024

Conversation

AlvinSchiller
Copy link
Collaborator

@AlvinSchiller AlvinSchiller commented Feb 16, 2024 •
edited
Loading

#2263

Seems like a new Version (2.0.0) of the plugin was released last week, that included breaking changes.
https://github.com/eclipse/paho.mqtt.python/blob/v2.0.0/docs/migrations.rst

@AlvinSchiller AlvinSchiller self-assigned this Feb 16, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7936579943

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.82%
Totals Coverage Status
Change from base Build 7898617476: 0.0%
Covered Lines: 633
Relevant Lines: 824
💛 - Coveralls

@AlvinSchiller AlvinSchiller added bug python legacy_v2 Issues, discussions and PRs related to Version 2.x labels Feb 16, 2024
@AlvinSchiller AlvinSchiller added this to the v2.6 milestone Feb 16, 2024
@AlvinSchiller AlvinSchiller changed the title add api version to client for new version 2.0.0 compatibility add api version to mqtt.client for new version 2.0.0 compatibility Feb 16, 2024
@s-martin
Copy link
Collaborator

User reported the fix works: #2263 (reply in thread)

So we could merge.

@AlvinSchiller AlvinSchiller merged commit c89b6fc into MiczFlor:develop Feb 19, 2024
10 checks passed
@AlvinSchiller AlvinSchiller deleted the fix/mqtt branch February 19, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-martin s-martin s-martin approved these changes

@pabera pabera Awaiting requested review from pabera

Assignees

@AlvinSchiller AlvinSchiller

Labels
bug ext dependency legacy_v2 Issues, discussions and PRs related to Version 2.x python
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvinSchiller @coveralls @s-martin