Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Vite instead of CRA #2476

Open
wants to merge 2 commits into
base: future3/develop
Choose a base branch
from
Open

Conversation

aflatter
Copy link

@aflatter aflatter commented Dec 30, 2024

I was curious about replacing CRA (which is not being worked on anymore) with Vite (which is probably the most direct replacement).

Notes:

  • eslint is configured tol run as part of the development server (as in CRA). Issues are displayed using the checker plugin.
  • All JS files that contain JSX have been renamed to .jsx as that's the easiest way to make them work with Vite.
  • I decided to go with SWC instead of Babel. Who doesn't like more efficient builds?
  • There don't seem to be any tests currently, so I have not integrated a testing setup.

Todos:

  • Make sure the CI passes
  • Make sure the run_rebuild.sh still behaves as intended.

@aflatter aflatter changed the base branch from develop to future3/develop December 30, 2024 22:34
@pabera pabera added the future3 Relates to future3 development label Dec 31, 2024
@pabera pabera added this to the v3.7 milestone Dec 31, 2024
@pabera pabera self-requested a review December 31, 2024 07:32
@aflatter aflatter marked this pull request as ready for review January 2, 2025 20:29
@aflatter
Copy link
Author

aflatter commented Jan 2, 2025

@pabera I set up the Docker environment as per the docs and fixed the port allocation. Marked the PR as ready for review to trigger the CI. Let me know if there's anything else I should check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future3 Relates to future3 development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants