Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Test Util #65

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Remove Test Util #65

merged 3 commits into from
Jun 20, 2024

Conversation

harrysolovay
Copy link
Contributor

We can use TestPublicKey directly from o1js via the Mina namespace export.

mitschabaude
mitschabaude previously approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, but you still need to fix some of the eg.ts tests

kantp
kantp approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@kantp kantp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@harrysolovay harrysolovay added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 2ec9dcb Jun 20, 2024
3 checks passed
@harrysolovay harrysolovay deleted the test-cleanup branch June 20, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kantp kantp kantp approved these changes

@mitschabaude mitschabaude mitschabaude left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harrysolovay @kantp @mitschabaude