-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Hard fork data migration #14288
Conversation
!ci-build-me |
@@ -0,0 +1,141 @@ | |||
p## Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to delete the p
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops
!ci-build-me |
These applications can be run in sequence to get a fully-migrated | ||
database. They should be able to work incrementally, so that part of | ||
the mainnet database can be migrated and, as new blocks are added on | ||
mainnet, the new data in the databannnnnse can be migrated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, again.
|
I would expect there will be a archive dump cron job for the new mainnet, which will write to the existing
The current mainnet archive dumps are named The current bucket is in Google Cloud Storage, not S3, which is an Amazon product. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
||
How do we limit the migration to the final block of mainnet? There could be | ||
flags to the migration apps to stop at a given state hash or height. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest ending migration at slot_tx_end
in RFC 51, #14138. We'll only have empty blocks for fork resolution after that anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, in the first-phase migration app, in #12906, I've add a --end-global-slot
command-line arg, and tested that. The second-phase app doesn't need to worry about the end slot, because it can only process what the first-phase app has produced.
If you omit that arg, the app will migrate only canonical blocks. My understanding is that there may be some pending blocks to be migration, so if you do provide that arg, the app will migrate both pending and canonical (but not orphaned) blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the unresolved question, because I think this command-line arg solves the problem.
!ci-build-me |
!approved-for-mainnet |
RFC on getting data from the mainnet archive db to a db using the
berkeley
schema.The branch
feature/berkeley-db-migrator
is used in #12906.The branch
feature/add-berkeley-account-tables
is used in #14339.Part of #12676.