Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Commenting some wrap related code #14309

Closed
wants to merge 1 commit into from

Conversation

dannywillems
Copy link
Member

Explain your changes:

  • Commenting wrap related code

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@dannywillems dannywillems requested review from a team as code owners October 9, 2023 16:01
@dannywillems dannywillems marked this pull request as draft October 9, 2023 16:02
@dannywillems dannywillems changed the base branch from develop to feature/fix-circuit-inconcistency October 9, 2023 16:02
@dannywillems dannywillems force-pushed the dannywillems/commenting-wrap-code branch from 8f9d174 to b299a5c Compare October 9, 2023 16:03
@dannywillems dannywillems force-pushed the dannywillems/commenting-wrap-code branch from b299a5c to 22ca67f Compare October 9, 2023 18:17
Base automatically changed from feature/fix-circuit-inconcistency to develop October 10, 2023 03:53
@mrmr1993
Copy link
Member

mrmr1993 commented Mar 4, 2024

Old, stale, and small. Closing.

@mrmr1993 mrmr1993 closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants