Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update account_subtree_height to 6 #14310

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Oct 9, 2023

Explain your changes:

  • Update account_subtree_height parameter to speed up sync ledger algorithm
  • Previous value of 3 was causing the algorithm to make far too many tiny RPC requests

Explain how you tested your changes:

  • Tested on a small cluster: deployed with small (200 accounts) genesis ledger, grew the ledger to ~200k accounts, repeatedly deleted a pod and allowed it to bootstrap
  • Tested various values for the constant (see gist), chose the best

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@georgeee georgeee requested a review from a team as a code owner October 9, 2023 18:47
@deepthiskumar
Copy link
Member

!ci-build-me

@deepthiskumar
Copy link
Member

!ci-nightly-me

@georgeee georgeee force-pushed the georgeee/account-subtree-height-6 branch from 5283bd8 to b19d41f Compare October 9, 2023 19:06
@georgeee
Copy link
Member Author

georgeee commented Oct 9, 2023

!ci-build-me

@deepthiskumar
Copy link
Member

!ci-nightly-me

@deepthiskumar
Copy link
Member

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar deepthiskumar merged commit 5217a1d into berkeley Oct 10, 2023
@deepthiskumar deepthiskumar deleted the georgeee/account-subtree-height-6 branch October 10, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants