Skip to content

Commit

Permalink
ugh… git commands are an inconsistency hell in itself
Browse files Browse the repository at this point in the history
git reflog expire --expire=a̲l̲l̲ is documented, even though the code
only uses parse_expiry_date() which handles all and now the same,
so --expire=now would also work (and is in fact recommended by git
help filter-branch but undocumented in git help reflog!); git gc
--prune=n̲o̲w̲ is handled specially, one use is parse_expiry_date()
(which also accepts --prune=all, which I’ve seen recommended lots
over the years), the other is a direct strcmp with "now" (matching
*its* documentation but not lots of info elsewhere)… so we now use
--expire=all --all and --prune=now despite wanting the identical
thing…
  • Loading branch information
mirabilos committed Aug 2, 2021
1 parent 63bc5c5 commit 94c4a15
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cvs2git
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ if (( do_grafts )); then
fi

$git reflog expire --expire=all --all || die "git reflog failed with errorlevel $?"
$git gc --aggressive --prune=all || die "git gc failed with errorlevel $?"
$git gc --aggressive --prune=now || die "git gc failed with errorlevel $?"
print -u2 "I: $SECONDS seconds elapsed for garbage collection"
for rem in "${remote[@]}"; do
print -ru2 "D: pushing to $rem"
Expand Down

0 comments on commit 94c4a15

Please sign in to comment.