Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Link the "Help" and "Contact Us" buttons on index webpage #107

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

barbeau
Copy link
Member

@barbeau barbeau commented Feb 25, 2022

Summary:

This PR adds hyperlinks to the "Help" and "Contact Us" buttons in the top bar of the index website:

image

Right now here are the hyperlinks, although these can be changed:

This PR also removes the "About" menu item, as that is ticketed separately in #52 with some work towards it in #84.

Closes #50.

Expected behavior:

Currently when clicking "Help" and "Contact Us" nothing happens. This PR adds hyperlinks to both.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with mvn test to make sure you didn't break anything
  • Format the title like "feat: {new feature short description}" or "fix: {describe what was fixed}". Title must follow the Conventional Commit Specification (https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@isabelle-dr
Copy link

Looks good, thanks for updating these links!

@isabelle-dr isabelle-dr merged commit 93e52bf into master Mar 10, 2022
@isabelle-dr isabelle-dr deleted the sean/help-contact-us branch March 10, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill in "Help" and "Contact Us" menu items
3 participants