Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dataset.to_file HDF5 functionality #715

Closed
wants to merge 1 commit into from
Closed

Fix Dataset.to_file HDF5 functionality #715

wants to merge 1 commit into from

Conversation

dotsdl
Copy link
Collaborator

@dotsdl dotsdl commented Apr 15, 2022

Description

Fixes broken Dataset.to_file HDF5 functionality.
Closes #714.

Changelog description

Fixed broken Dataset.to_file HDF5 functionality.

Status

  • Code base linted
  • Ready to go

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #715 (275ba8d) into master (ceff64f) will decrease coverage by 12.09%.
The diff coverage is 100.00%.

@dotsdl dotsdl mentioned this pull request Apr 15, 2022
@dotsdl
Copy link
Collaborator Author

dotsdl commented Apr 15, 2022

Note, need to set the dataset units for use with anything but driver='energy' datasets. For example, with a driver='gradient' dataset:

from qcfractal.interface import FractalClient

fc = FractalClient()

ds = fc.get_collection('Dataset', 'SPICE PubChem Set 1 Single Points Dataset v1.2')
ds.units = "hartree / bohr"

ds.to_file('test.hdf5', 'hdf5')

@bennybp
Copy link
Contributor

bennybp commented Sep 14, 2023

No longer applicable to v0.50, although we might add HDF5 back into it at some point

@bennybp bennybp closed this Sep 14, 2023
@bennybp bennybp deleted the fix-hdf5 branch January 11, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset HDF5 broken
2 participants