Migrate away from datetime.utctime() & make server more timezone aware #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
datetime.utctime()is being deprecated in python 3.12. This migrates to using fully timezone-aware TIMESTAMP columns in postgres, as well as a function for generating UTCdatetimeobjects that are timezone aware.The DB still stores the timestamps internally as UTC times, but now the resulting
datetimeobjects in the ORM will contain the timezone. This will also make interfacing with the client easier (ie, querying records based on times should work better if the user specifies a timezone)Changelog description
Migrate away from datetime.utctime() & make server more timezone aware
Status