Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component data #9

Merged
merged 7 commits into from
Apr 16, 2024
Merged

component data #9

merged 7 commits into from
Apr 16, 2024

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Apr 15, 2024

  • set qcvars/MBResultProp for g/H
  • return species data (e/g/H as available) in a new ManyBodyResult field component_data.
    • Could be component_results. But now I'm thinking component_properties that's a Dict[str, AtomicResultProperties] would be good. pretty much the only filled fields would be return_energy, return_gradient, etc. maybe nuclear_repulsion_energy. might entail a schema change if one suddenly wanted to add NMR as a collected property would be the only reason not ANS: component_properties
    • pre- or post-expansion of arrays? right now it's set to pre b/c there's something in psi that expects it, but I'm favoring post. ANS: post-
    • all the array naming is sloppy until field name finalized
  • some docstrings
  • renamed manybody_v1 to manybody_pydv1.py to emphasize pydantic version not schema version
  • renamed expand_gradient/hessian to resize_gradient/hessian, made them reversible, and added docstrings. In future, consider non-contig fragments and removing one of size_dict or slice_dict.

@loriab loriab merged commit 0ac94f9 into MolSSI:main Apr 16, 2024
3 checks passed
@loriab loriab deleted the misc1 branch April 16, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant