Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
component_data
.Could beANS:component_results
. But now I'm thinkingcomponent_properties
that's aDict[str, AtomicResultProperties]
would be good. pretty much the only filled fields would bereturn_energy
,return_gradient
, etc. maybenuclear_repulsion_energy
. might entail a schema change if one suddenly wanted to add NMR as a collected property would be the only reason notcomponent_properties
pre- or post-expansion of arrays? right now it's set to pre b/c there's something in psi that expects it, but I'm favoring post.ANS: post-all the array naming is sloppy until field name finalizedmanybody_v1
tomanybody_pydv1.py
to emphasize pydantic version not schema versionexpand_gradient/hessian
toresize_gradient/hessian
, made them reversible, and added docstrings. In future, consider non-contig fragments and removing one of size_dict or slice_dict.