Removed openseesvis package import and dependency #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinngan92
approved these changes
Apr 24, 2024
justinngan92
approved these changes
Apr 24, 2024
justinngan92
approved these changes
Apr 24, 2024
ccaprani
reviewed
Apr 24, 2024
| @@ -17,7 +17,6 @@ | |||
| from ospgrillage.load import ShapeFunction | |||
| from ospgrillage.static import solve_zeta_eta | |||
|
|
|||
| import openseespyvis.Get_Rendering as opsplt | |||
There was a problem hiding this comment.
Can't delete this variable; it is used throughout codebase. #74 redfines it with vfo which is now accepted. Pull again and check it works.
|
Hello @shihabkhan1 , |
|
@justinngan92 Similar to the other PR, can you rebase onto #74 and see if we can merge please? |
|
Closed based on DM from @justinngan92 that this is now incorporated into #86 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now package is able to install and work..