-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ Apply Forest root changes to Buckets in Blockchain Service #335
Open
ffarall
wants to merge
50
commits into
main
Choose a base branch
from
feat/forest-root-catch-ups-msp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elete_file` tasks
…own the bucket ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #312.
In this PR:
MutationsApplied
event inapply_forest_root_changes
of the Blockchain Service, to apply forest root changes of MSPs.insert_files_metadata
call frommsp_upload_file
, now that this is done in the Blockchain Service.query_buckets_for_msp
new runtime API to Providers pallet.event_info
togeneric_apply_delta
function fromProofsDealerInterface
. The intention is that users of this interface can pass aVec<u8>
of encoded info for context on what the delta is applied on. For the purpose of this PR, that is used for the File System pallet to pass down the encoded Bucket ID.