Don't default to ProfileType SURVIVAL for spectator gamemode change. #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume you tested this right? And does it work fine if you from Creative to Spectator to Survival? |
|
It works fine from my testing yea. |
|
actually wait, let me test again just to be sure |
This improves performance slightly as it doesnt rewrite SURVIVAL to SURVIVAL when changing from survival to spectator. There is no need to read or write anything to gamemode spectator.
benwoo1110
force-pushed
the
spectator-gamemode-efficiency
branch
from
bdf5dcf to
c5fc189
Compare
|
Yea ok it works, missed out doing the same thing for ReadProfile jn. |
|
Okay, seems good to me, but just to be sure... @dumptruckman please take a look lol. |
benwoo1110
added
PR: Better Coding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to solve #458, just happened to notice this.
This improves performance slightly as it doesnt rewrite SURVIVAL to SURVIVAL when changing from survival to spectator. There is no need to read or write anything to gamemode spectator.