MCR-3198 event handler for merging duplicate categories #2267
Conversation
mycore-base/src/main/java/org/mycore/common/xml/MCRURIResolver.java
Outdated
Show resolved
Hide resolved
|
In the video conference yesterday the question came up whether to include the new code in the MCRClassificationMappingEventHandler or leave it in its own EventHandler. |
mycore-mods/src/test/java/org/mycore/mods/merger/MCRCategoryMergeEventHandlerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I have created further test cases, not all of which work and for which I am not necessarily sure what the expected result actually is. The description of the issue doesn't provide enough information. You can merge this PR into this PR to obtain these test cases.
But as it is, I think too many cases are not (correctly) taken into account. Maybe the issue (and then the event handler implementation) needs to be reduced in scope in order to to get rid of these problems.
This probably needs to be discussed again in the next web conference.
…s properly processed + check displayLabel + refactor tests
|
After our conversation on the 3rd of December I implemented the discussed changes. The Handlers are now ready for review. |
mycore-mods/src/main/java/org/mycore/mods/merger/MCRRedundantModsGenreEventHandler.java
Outdated
Show resolved
Hide resolved
mycore-mods/src/main/java/org/mycore/mods/merger/MCRRedundantModsGenreEventHandler.java
Outdated
Show resolved
Hide resolved
mycore-mods/src/main/java/org/mycore/mods/merger/MCRRedundantModsGenreEventHandler.java
Outdated
Show resolved
Hide resolved
mycore-mods/src/main/java/org/mycore/mods/merger/MCRRedundantModsGenreEventHandler.java
Outdated
Show resolved
Hide resolved
mycore-mods/src/main/java/org/mycore/mods/merger/MCRAbstractRedundantModsEventHandler.java
Outdated
Show resolved
Hide resolved
...re-mods/src/main/java/org/mycore/mods/merger/MCRRedundantModsClassificationEventHandler.java
Outdated
Show resolved
Hide resolved
mycore-mods/src/main/java/org/mycore/mods/merger/MCRAbstractRedundantModsEventHandler.java
Outdated
Show resolved
Hide resolved
mycore-mods/src/main/java/org/mycore/mods/merger/MCRAbstractRedundantModsEventHandler.java
Outdated
Show resolved
Hide resolved
...re-mods/src/main/java/org/mycore/mods/merger/MCRRedundantModsClassificationEventHandler.java
Outdated
Show resolved
Hide resolved
...re-mods/src/main/java/org/mycore/mods/merger/MCRRedundantModsClassificationEventHandler.java
Outdated
Show resolved
Hide resolved
erodde
dismissed
toKrause’s stale review
We discussed open points and I refactored the code.
Link to jira.